Issue763

Title CountdownTimer: use methods to explicitly ask for elapsed or remaining time
Priority wish Status resolved
Superseder Nosy List jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2018-03-15.11:17:13 by silvan, last changed by patfer.

Messages
msg6907 (view) Author: malte Date: 2018-03-16.15:26:24
Looks good to merge, thanks! :-)
msg6906 (view) Author: silvan Date: 2018-03-16.15:25:27
That's strange, fixed it.
msg6905 (view) Author: malte Date: 2018-03-16.15:22:47
Your last commit message is lying: the diff only contains one of the two changes.

https://bitbucket.org/SilvanS/fd-dev/commits/0c71559b5f6dae358cd816e79bc0cd60abd465e2?at=default
msg6903 (view) Author: silvan Date: 2018-03-16.15:21:07
Right, I messed up the order of the parameters.
msg6899 (view) Author: malte Date: 2018-03-16.15:03:51
Two more comments, this time more important. :-) (I think with the latest change
all reported times should be 0 because we count things negatively and change all
negative values to 0?)
msg6895 (view) Author: silvan Date: 2018-03-16.14:44:19
Done with addressing them.
msg6887 (view) Author: malte Date: 2018-03-16.12:49:31
I've made some more comments.
msg6885 (view) Author: jendrik Date: 2018-03-16.12:31:19
From my point of view it is.
msg6883 (view) Author: silvan Date: 2018-03-16.12:24:25
I addressed all comments, is this ready for merging?
msg6860 (view) Author: malte Date: 2018-03-15.13:21:30
I'm done with my comments.
msg6858 (view) Author: jendrik Date: 2018-03-15.12:22:29
Looks good to me. I left one minor comment.
msg6852 (view) Author: silvan Date: 2018-03-15.12:01:23
Pull request: https://bitbucket.org/SilvanS/fd-dev/pull-requests/33/issue763/diff
msg6848 (view) Author: silvan Date: 2018-03-15.11:17:13
Currently, CountdownTimer objects, if passed to an output stream, print the
elapsed time and not the remaining time, which at least Malte and I found
surprising. We want to change the Timer class to return a simple wrapper of
double that can be used as a double or formatted for printing. CountdownTimer,
using the Timer class internally, will do the same for both of its methods
"get_elapsed_time" and "get_remaining_time".
History
Date User Action Args
2018-03-16 16:19:05patfersetstatus: reviewing -> resolved
2018-03-16 15:26:24maltesetmessages: + msg6907
2018-03-16 15:25:27silvansetmessages: + msg6906
2018-03-16 15:22:47maltesetmessages: + msg6905
2018-03-16 15:21:07silvansetmessages: + msg6903
2018-03-16 15:03:51maltesetmessages: + msg6899
2018-03-16 14:44:19silvansetmessages: + msg6895
2018-03-16 12:49:31maltesetmessages: + msg6887
2018-03-16 12:31:19jendriksetmessages: + msg6885
2018-03-16 12:24:25silvansetmessages: + msg6883
2018-03-15 13:21:30maltesetmessages: + msg6860
2018-03-15 12:22:29jendriksetstatus: in-progress -> reviewing
messages: + msg6858
2018-03-15 12:01:23silvansetmessages: + msg6852
2018-03-15 11:21:47jendriksetnosy: + jendrik
2018-03-15 11:17:13silvancreate