Issue828

Title One class for storing all Predefinitions
Priority feature Status resolved
Superseder Nosy List cedric, jendrik, malte, salome
Assigned To cedric Keywords
Optional summary

Created on 2018-09-18.15:37:07 by salome, last changed by cedric.

Messages
msg7571 (view) Author: cedric Date: 2018-09-19.14:41:48
Merged and pushed
msg7564 (view) Author: malte Date: 2018-09-19.12:38:29
Feel free to merge, this doesn't need another review.
msg7563 (view) Author: cedric Date: 2018-09-19.12:37:19
Comments incorporated
msg7546 (view) Author: jendrik Date: 2018-09-18.22:10:51
I had a look and think the code looks good (even better after the minor comments 
are addressed :-)).
msg7544 (view) Author: malte Date: 2018-09-18.21:20:44
I had a quick look, but I'm tired, so it'd be good if someone else could have a
look, too. :-) Looks good to merge for me.
msg7543 (view) Author: salome Date: 2018-09-18.20:25:20
Here is the pull request:
https://bitbucket.org/cgeissmann/downward/pul
l-requests/8/only-use-one-predefinitions/diff
msg7529 (view) Author: jendrik Date: 2018-09-18.18:01:37
On the task board it says "waiting for review". Could you please post a link to 
the pull request?
msg7522 (view) Author: salome Date: 2018-09-18.15:37:07
Currently, the class that stores predefined objects in the option parser (like
predefined heuristics) is templated. We want to get rid of the templatization by
having one non-templated class containing a map which maps type_index to a
storage object which in turn stores all objects of this type. An example of how
this can work is already implemented in PluginTypeRegistry.
History
Date User Action Args
2018-09-19 14:41:48cedricsetstatus: reviewing -> resolved
assignedto: cedric
messages: + msg7571
2018-09-19 12:38:29maltesetmessages: + msg7564
2018-09-19 12:37:19cedricsetmessages: + msg7563
2018-09-18 22:10:51jendriksetstatus: chatting -> reviewing
messages: + msg7546
2018-09-18 21:20:44maltesetmessages: + msg7544
2018-09-18 20:25:20salomesetmessages: + msg7543
2018-09-18 20:24:17salomesetmessages: - msg7542
2018-09-18 20:23:54salomesetmessages: + msg7542
2018-09-18 18:01:37jendriksetnosy: + jendrik
messages: + msg7529
2018-09-18 15:43:05cedricsetnosy: + cedric
2018-09-18 15:37:07salomecreate